Skip to content

Unnecessary ext folder #69

Closed
Closed

Description

@grant

The repo has a folder of the CE spec in JSON format in ext.

https://github.com/cloudevents/sdk-javascript/tree/master/ext

While this may be useful, it's not necessary for a CloudEvent SDK. Let's refer back to the spec rather than keeping the files.

Activity

  1. grant commented on Apr 28, 2020

    @grant
    MemberAuthor

    It looks like these specs might be currently used. I'll keep this open but close the PR.

  2. lance commented on May 4, 2020

    @lance
    Member

    This issue is related to #96. The .json in ext/ is used to validate the data in an event using the AJV validator. I don't think this should be removed.

  3. grant commented on May 4, 2020

    @grant
    MemberAuthor

    Yes, it shouldn't be removed unless there is a replacement validator.

  4. lance commented on May 6, 2020

    @lance
    Member

    Closing. Fixed in #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions