Skip to content

fix #111 Duration filter of the executions: bind the values as DQL parameters - #112

Merged
njoubert-cleverage merged 2 commits into
mainfrom
111
Oct 8, 2026
Merged

njoubert-cleverage merged 2 commits into
mainfrom
111

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #111.

ProcessExecutionDurationFilter::apply(): the filter values are bound as parameters (named after FilterDataDto::getParameterName() / getParameter2Name(), unique per filter) instead of being concatenated in the DQL. The comparison operator is still checked against the allowed list (now in strict mode).

Tests: ProcessExecutionDurationFilterTest asserts the DQL with the parameters and their bound values; the functional filter test (ProcessExecutionCrudTest::testFilters) runs the query (SQLite).

Checked:

  • bundle (Symfony 8.1, PHP 8.5): 266 tests OK. PHPStan, PHP-CS-Fixer, Rector OK
  • process-bundle-demo, MySQL 9.1: >= 1 and between 0 and 1 give the same counts as the equivalent SQL queries (168, 995)
  • PostgreSQL 16 (throwaway container, schema from the migrations): > 60, <= 10 and between 1 and 10 return the expected executions

Requirements

  • Documentation updates
    • Reference
    • Changelog
  • Unit tests

Breaking changes

None.

🤖 Generated with Claude Code

…rameters

The values were concatenated in the DQL with sprintf(), only protected by the numeric form field.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage njoubert-cleverage added the enhancement New feature or request label Oct 7, 2026
@njoubert-cleverage
njoubert-cleverage merged commit 304fe11 into main Oct 8, 2026
18 checks passed
@njoubert-cleverage
njoubert-cleverage deleted the 111 branch October 8, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duration filter of the executions: bind the values as DQL parameters

1 participant