Repository navigation
fix #111 Duration filter of the executions: bind the values as DQL parameters - #112
Merged
Merged
Conversation
…rameters The values were concatenated in the DQL with sprintf(), only protected by the numeric form field. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #111.
ProcessExecutionDurationFilter::apply(): the filter values are bound as parameters (named afterFilterDataDto::getParameterName()/getParameter2Name(), unique per filter) instead of being concatenated in the DQL. The comparison operator is still checked against the allowed list (now in strict mode).Tests:
ProcessExecutionDurationFilterTestasserts the DQL with the parameters and their bound values; the functional filter test (ProcessExecutionCrudTest::testFilters) runs the query (SQLite).Checked:
>= 1andbetween 0 and 1give the same counts as the equivalent SQL queries (168, 995)> 60,<= 10andbetween 1 and 10return the expected executionsRequirements
Breaking changes
None.
🤖 Generated with Claude Code