Skip to content

Duration filter of the executions: bind the values as DQL parameters #111

Closed

Description

@njoubert-cleverage

Description

ProcessExecutionDurationFilter (duration filter of the process executions list) inserts the filter values (value, value2) in the DQL with sprintf() instead of binding them as parameters.

Not exploitable as is: the filter form field is numeric (NumericFilterType), and EasyAdmin does not apply a filter whose form is invalid; a value such as 3600, 'SECOND') OR (1=1 OR ... is handled as an invalid value. But the protection only relies on the form validation: hardening.

Tested on main (e298007).

Cause

ProcessExecutionDurationFilter::apply()

Proposed fix

Bind the values as parameters (named after FilterDataDto::getParameterName() / getParameter2Name(), unique per filter); DQL date_add() accepts a parameter. Check the query on MySQL and PostgreSQL.

Requirements

  • Documentation updates
    • Reference
    • Changelog
  • Unit tests

Breaking changes

None.

Activity

  1. added a commit that references this issue on Oct 8, 2026
    304fe11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions