Repository navigation
#459 - process_launcher: stop the sub-processes together - #460
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
459
branch
from
November 4, 2026 18:25
4b4bde9 to
32c675f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #459:
ProcessLauncherTaskstops its sub-processes together (new protectedstopProcesses(), used byfinalize()andkillProcesses()):SIGTERMto all the running ones, a single wait of up to 5 seconds (STOP_TIMEOUT), thenSIGKILL(stop(0)) to the ones still running. A signal that cannot be sent (terminated in the meantime, Windows) falls back tostop(0). The reference page says it.Checked locally:
SIGTERM, a timeout of 1 s: all stopped in 1 to 2 s (3 s one after the other);Requirements
Breaking changes
None.
🤖 Generated with Claude Code