Skip to content

#459 - process_launcher: stop the sub-processes together - #460

Merged
njoubert-cleverage merged 2 commits into
mainfrom
459
Nov 4, 2026
Merged

njoubert-cleverage merged 2 commits into
mainfrom
459

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #459: ProcessLauncherTask stops its sub-processes together (new protected stopProcesses(), used by finalize() and killProcesses()): SIGTERM to all the running ones, a single wait of up to 5 seconds (STOP_TIMEOUT), then SIGKILL (stop(0)) to the ones still running. A signal that cannot be sent (terminated in the meantime, Windows) falls back to stop(0). The reference page says it.

Checked locally:

  • new test (with pcntl): 3 sub-processes ignoring SIGTERM, a timeout of 1 s: all stopped in 1 to 2 s (3 s one after the other);
  • highest dependencies (PHP 8.5), with pcov coverage: all tests OK, no risky; PHPStan, PHP-CS-Fixer and Rector OK.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

None.

🤖 Generated with Claude Code

@njoubert-cleverage
njoubert-cleverage requested a review from a team as a code owner November 4, 2026 15:00
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 9e41d03 into main Nov 4, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process_launcher: the sub-processes are stopped one after the other, up to 5 seconds each

1 participant