You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
process_launcher: the sub-processes are stopped one after the other, up to 5 seconds each #459
ProcessLauncherTask::finalize() and killProcesses() stop the running sub-processes one after the other with stop(5): each one gets SIGTERM and up to 5 seconds before SIGKILL, the next one only after.
With 8 sub-processes ignoring or slowly handling SIGTERM, stopping them takes up to 40 seconds, longer than the grace period of docker stop (10 s) or of Kubernetes (30 s): the parent process is killed in the middle of finalize(), its execution stays started (cleverage/ui-process-bundle), and the remaining sub-processes are left as orphans.
Proposed fix
Send SIGTERM to all of them, wait for them together up to the timeout, then SIGKILL the ones still running.
Activity
#459 - Fix the section of the CHANGELOG entry
#459 - process_launcher: stop the sub-processes together
#459 - Fix the section of the CHANGELOG entry
Merge pull request #460 from cleverage/459