Repository navigation
#394 - Keep the error of the process when a listener of cleverage_process.fail fails, remove the misleading debug message - #395
Merged
Conversation
…cess.fail fails, remove the misleading debug message on error outputs with the stop strategy Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #394.
cleverage_process.fail:ProcessManager::execute()catches an exception thrown while dispatchingProcessEvent::EVENT_PROCESS_FAILED. It logs it as an error on the process logger ("A listener of the process failure has failed", with theexception), then rethrows the error of the process. Until now, the error of the listener escaped instead, so the command, a parent process (process_executor) and Messenger lost the originalProcessFailedException. As before, the listeners after the failing one are not called (the dispatch is interrupted).ProcessManager::initialize(). The error branch of a task with thestopstrategy is executed before the process stops, as documented in04-advanced_workflow.md.Requirements
Breaking changes
None. An application that relied on the exception of its
cleverage_process.faillistener escaping fromexecute()now gets the error of the process, and the exception of the listener is logged.🤖 Generated with Claude Code