Skip to content

A listener of cleverage_process.fail replaces the error of the process; misleading debug message on error outputs with the stop strategy #394

Closed

Description

@njoubert-cleverage

Two issues in the failure handling of ProcessManager:

  • A listener of cleverage_process.fail replaces the error of the process: an exception thrown by a listener of ProcessEvent::EVENT_PROCESS_FAILED (e.g. a notification or a database write failing) escapes from ProcessManager::execute() instead of the ProcessFailedException of the process. The command, a parent process (process_executor) and Messenger get the error of the listener, the original error is lost.
  • Misleading debug message: for a task with the stop error strategy and error_outputs, ProcessManager::initialize() logs "has error outputs but it's error strategy 'stop' implies they will never be reached". It is wrong: the error branch is executed before the process stops, as documented in 04-advanced_workflow.md.

Fix: catch the exceptions of the cleverage_process.fail listeners, log them as an error and rethrow the error of the process; remove the debug message.

Found during the audit v3 (audit-v3-angles.md #178, #173).

Activity

  1. added a commit that references this issue on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions