Repository navigation
#390 - cleverage:process:execute: a JSON output that cannot be encoded no longer makes the command fail - #391
Merged
Merged
Conversation
…utput, report an output that cannot be encoded instead of failing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #390.
Change of 5.5 (#353): with
--output-format=json-streamand STDOUT, the output is printed whatever the verbosity, and an output that cannot be encoded as JSON threw aJsonExceptionafter the execution: the command failed and the next processes were skipped (before 5.5, nothing was printed without-vv).JSON_INVALID_UTF8_SUBSTITUTE(e.g. a Latin-1 file read): invalid sequences are replaced by U+FFFD.NAN,INF...) is reported on the error output, and the next processes are executed.UPGRADE.md(v5.5 section):--output-format=dumpwithoutsymfony/var-dumper, or an unknown format, makes the command fail before any execution (kept: a wrong option is detected before the work is done).01-quick_start.mdupdated.--outputfile is unchanged:JsonStreamFilethrows on an output that cannot be encoded, as before 5.5.Requirements
Breaking changes
None: the command no longer fails on such an output.
🤖 Generated with Claude Code