You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cleverage:process:execute: output options silently ignored, invalid options detected after the execution #353
cleverage:process:execute handles its output options badly:
-t json-stream / -t dump to STDOUT (the default --output) print nothing without -vv: the output asked for explicitly is silently dropped.
-o <file> -t json-stream writes nothing, without any message, when the output of the process is not an array (// TODO how to handle other cases ?): the output is lost, also for process_launcher with json_buffering.
An invalid --output-format is only detected after the process has been executed (exit code 1, after the work is done); an unknown process code is only detected when its turn comes, after the execution of the previous processes; -t dump without symfony/var-dumper fails with "Cannot handle data output with format 'dump'".
Fix: check the process codes and the output format before executing anything (explicit message for dump without VarDumper); print the output to STDOUT whatever the verbosity when an output format is given; write a warning on the error output when a non-array output cannot be written as JSON stream.
Found during the global audit after the 5.4 release (process-bundle-audit.md#84).
Activity
Merge pull request #354 from cleverage/353