You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
State on main @ cd7b81f (v5.3), for step 2: config/services/task.yaml and config/services/transformer.yaml still load src/Task/* and src/Transformer/* as resources with autowire: true (+ autoconfigure: true for transformers) and bind. The best practices for reusable bundles say bundle services should not use autowiring nor autoconfiguration: their dependencies then depend on the aliases available in the application.
Step 2 = one explicit definition per task/transformer, with cleverage_process.* ids and FQCN aliases (task service: '@CleverAge\ProcessBundle\Task\...' references must keep working), explicit arguments instead of bind, explicit tags.
Related: #275 (task locator) and #114 (private tasks) change how tasks are fetched, #276 adds a code tag attribute on transformers, #277 converts the definitions to PHP. Doing step 2 after #275/#276 avoids writing the definitions twice.
Moved out of the v6.0 milestone (next 5.x minor): replacing the autowired resources of config/services/task.yaml / transformer.yaml by explicit definitions is not a BC break as long as the service ids (the class names), public / shared, tags and arguments stay the same. Edge case to mention in the PR: today the arguments are autowired from the application aliases (e.g. a custom PropertyAccessorInterface alias), an explicit wiring to the bundle services would no longer use them. Still to do after #275 / #276, which change how tasks and transformers are fetched. Not in conflict with #272 (autoconfiguration of the application services implementing TaskInterface / TransformerInterface).
Activity
[-]Services[/-][+]Apply Symfony best practices - Services[/+]njoubert-cleverage commentedon Oct 14, 2026
State on
main@cd7b81f(v5.3), for step 2:config/services/task.yamlandconfig/services/transformer.yamlstill loadsrc/Task/*andsrc/Transformer/*as resources withautowire: true(+autoconfigure: truefor transformers) andbind. The best practices for reusable bundles say bundle services should not use autowiring nor autoconfiguration: their dependencies then depend on the aliases available in the application.Step 2 = one explicit definition per task/transformer, with
cleverage_process.*ids and FQCN aliases (taskservice: '@CleverAge\ProcessBundle\Task\...'references must keep working), explicit arguments instead ofbind, explicit tags.Related: #275 (task locator) and #114 (private tasks) change how tasks are fetched, #276 adds a
codetag attribute on transformers, #277 converts the definitions to PHP. Doing step 2 after #275/#276 avoids writing the definitions twice.njoubert-cleverage commentedon Oct 14, 2026
Moved out of the v6.0 milestone (next 5.x minor): replacing the autowired resources of
config/services/task.yaml/transformer.yamlby explicit definitions is not a BC break as long as the service ids (the class names),public/shared, tags and arguments stay the same. Edge case to mention in the PR: today the arguments are autowired from the application aliases (e.g. a customPropertyAccessorInterfacealias), an explicit wiring to the bundle services would no longer use them. Still to do after #275 / #276, which change how tasks and transformers are fetched. Not in conflict with #272 (autoconfiguration of the application services implementingTaskInterface/TransformerInterface).Merge pull request #291 from cleverage/149
#91 - Tasks and transformers keep their class name as service id, dep…