Skip to content

Tasks services should not be public #114

Closed

Description

@johnkrovitch

To respect the Symfony coding and the good practice, the tasks services should not be public

Activity

  1. shavounet commented on Sep 17, 2021

    @shavounet
    Contributor

    Needs to use a registry or service locator pattern.

  2. added this to the v5.0 milestone on Dec 16, 2024
  3. modified the milestones: v5.0, v6.0 on Dec 9, 2025
  4. njoubert-cleverage commented on Oct 14, 2026

    @njoubert-cleverage
    Member

    v5 preparation step: #275 (tasks fetched from a service locator built at compile time from the process configurations, with a deprecated fallback on the container). Once it is released, this ticket = remove the container argument and the fallbacks from ProcessManager / ProcessHelpCommand, make the bundle tasks private, and make the FQCN aliases of the bridge bundle tasks private.

  5. removed this from the v6.0 milestone on Oct 14, 2026
  6. njoubert-cleverage commented on Oct 14, 2026

    @njoubert-cleverage
    Member

    Handled by #275 (PR #290): the tasks are fetched from a service locator built from the process configurations, so task services no longer need to be public (private services and aliases work, documentation updated). Removed from the v6.0 milestone; this issue will be closed by PR #290. What remains for v6.0 is only the removal of the deprecated fallbacks ($container argument of ProcessManager / ProcessHelpCommand, container fallback of TaskRegistry), with the other deprecated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions