Repository navigation
perf(mosaic): re-render only the table rows whose selection changes - #10624
Open
alexcarpenter wants to merge 1 commit into
Open
alexcarpenter wants to merge 1 commit into
alexcarpenter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
🦋 Changeset detectedLatest commit: 401320e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Selecting a
Tablerow re-rendered every row, because each row read the selection and expanded state from the table context, which changed on every click. Rows now read that state from a store throughuseStore(added in #10621), and the context value stays stable, so only the rows whose state changed re-render.Time from a row checkbox click to the next frame, in Chromium at 4× CPU (median):
The feature tables (organization members, requests and invitations, API keys) show 10 rows per page, so they already missed a frame on every selection.
Event handlers that only need the current selection read it with
store.get()when the event fires, so they don't subscribe.Stacked on #10621.
Checklist
pnpm testruns as expected (@clerk/mosaic).pnpm buildruns as expected.Type of change