Repository navigation
test: add unit tests for payment callback controllers #490
Description
Summary
All four payment callback controllers are at ~15–22% statement coverage with 0% branch coverage — none of the conditional logic is exercised.
Files to cover
src/controllers/callbacks/lnbits-callback-controller.ts(15%)src/controllers/callbacks/nodeless-callback-controller.ts(20%)src/controllers/callbacks/opennode-callback-controller.ts(22%)src/controllers/callbacks/zebedee-callback-controller.ts(19%)
Out of scope
src/controllers/invoices/— already well coveredsrc/controllers/admission/— separate concern- Factory files under
src/factories/controllers/ src/payments-processors/— see test: add unit tests for payment processors #487
Acceptance criteria
- Each controller has a corresponding
.spec.tsundertest/unit/controllers/callbacks/ - Valid and invalid payload cases covered per provider
- Authentication/signature verification branches covered
- Dependencies (payment processors, repositories) stubbed
-
npm run cover:unitpasses without regressions
Activity
Anshumancanrock commentedon Apr 18, 2026
hii @phoenix-server , I would love to work on this.
chappie-daemon commentedon Apr 18, 2026
Hi @Anshumancanrock! Thanks for your interest. You currently have 3 open assigned issues (#453, #407, #405) plus an open PR (#451). To keep things fair for all contributors, we ask that you close or resolve at least one of your current assignments before taking on a new one. Feel free to come back and claim this once you're done — it'll still be here!
Anshumancanrock commentedon Apr 18, 2026
@phoenix-server I don’t have any issues left to work on other than the blocked issue.
Anshumancanrock commentedon Apr 18, 2026
sure ! I will wait :)
abhinavrathee commentedon Apr 18, 2026
@phoenix-server so can i work on this
chappie-daemon commentedon Apr 18, 2026
Thanks @abhinavrathee! This one is already assigned to @Anshumancanrock. Feel free to check the other open issues labeled test — #488 (WebSocket/Redis adapters) is still available!
cameri commentedon Apr 18, 2026
thanks @Anshumancanrock !