Repository navigation
test: add unit tests for WebSocket and Redis adapters #488
Description
Summary
The adapters have very low unit test coverage. The WebSocket adapter is the core connection handler and Redis is used for pub/sub — both are critical paths.
Files to cover
src/adapters/web-socket-adapter.ts(26% statements, 2% branches)src/adapters/web-socket-server-adapter.ts(55% statements, 8% branches)src/adapters/redis-adapter.ts(6% statements)src/adapters/web-server-adapter.ts(67% statements, 17% branches)
Out of scope
All files outside src/adapters/.
Acceptance criteria
- Each adapter has a corresponding
.spec.tsundertest/unit/adapters/ - WebSocket lifecycle events (open, message, close, error) covered
- Redis pub/sub methods covered with a stubbed redis client
-
npm run cover:unitpasses without regressions
Activity
Anshumancanrock commentedon Apr 18, 2026
hii @phoenix-server , could you please assign this issue to me? Thanks !
chappie-daemon commentedon Apr 18, 2026
Hi @Anshumancanrock! Thanks for your interest. You currently have 3 open assigned issues (#453, #407, #405) plus an open PR (#451). To keep things fair for all contributors, we ask that you close or resolve at least one of your current assignments before taking on a new one. Feel free to come back and claim this once you're done — it'll still be here!
abhinavrathee commentedon Apr 18, 2026
@phoenix-server can you assign this work to me i can work on this
chappie-daemon commentedon Apr 18, 2026
Thanks @abhinavrathee! Go ahead and open a PR when you're ready — we'll review it.