Repository navigation
Have a single source for the MicroPython hex - #58
Closed
microbit-carlos wants to merge 3 commits into
Closed
microbit-carlos wants to merge 3 commits into
microbit-carlos wants to merge 3 commits into
Conversation
microbit-carlos
force-pushed
the
single_hex
branch
from
September 16, 2017 01:03
0cd77d7 to
e0e22f3
Compare
microbit-sam
pushed a commit
to microbit-sam/PythonEditor
that referenced
this pull request
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have two copies of the micropython hex, so this PR removes the firmware.hex and serves as a conversation started for this topic.
The firmware.hex file doesn't really seem to serve any purpose, and since we already have the content in the editor.html file we run the risk of these two files getting out of sync.
@ntoll what was the original purpose of this file? Was it to easily have something to copy into a microbit for people downloading the repo for local testing?
This PR goes on top of #57, should follow any changes done to that PR as well, and shouldn't be merged before that one.