Highlight changed lines in the editor and stage them #46

Activity

1. joshaber

   added this to the 2: Committing from a selection / Committing editor integrationThis milestone has been deleted milestone on Feb 26, 2016
2. joshaber commented on Feb 26, 2016

   

   joshaber

   on Feb 26, 2016

   ContributorAuthor

   More actions

   @simurai I couldn't find any wireframes for this.
3. joshaber

   changed the title [-]Highlight lines in the editor and stage them[/-] [+]Highlight changed lines in the editor and stage them[/+] on Feb 26, 2016
4. simurai commented on Feb 27, 2016

   

   simurai

   on Feb 27, 2016

   Contributor

   More actions

   Added a wireframe, but it doesn't really show much. I would say:

   1. Make a selection around changes.
   2. Run git:stage-selection
   3. The changes that are within the selection get staged.

   This way you can stage lines without having to go to the diff view. Downside, you need to learn yet another keybinding.
5. benogle commented on Feb 29, 2016

   

   benogle

   on Feb 29, 2016

   Contributor

   More actions

   Would it focus the commit box? I think it depends on how #47 shakes out. What if it didnt, but the fix for #47 staged, then focused the commit box? Not sure.
6. simurai commented on Mar 1, 2016

   

   simurai

   on Mar 1, 2016

   Contributor

   More actions

   Would it focus the commit box?

   Hmm.. good question. I would say no. If you want to "select + stage + commit" something, then you would do #47 directly.

   I guess this feature would be an alternative to staging/unstaging in the diff view. Like when you know that your next commit will be split up, you can keep staging while you code. Instead of trying to remember later once you open the diff view.
7. joshaber commented on Mar 11, 2016

   

   joshaber

   on Mar 11, 2016

   ContributorAuthor

   More actions

   @simurai Is this:

   

   Or is it different?
8. simurai commented on Mar 11, 2016

   

   simurai

   on Mar 11, 2016

   Contributor

   More actions

   Close, but a bit different. It doesn't show staging a selection, but rather staging/unstaging/discarding a single line with the mouse. I guess it would be a step further after showing if a change is staged or not. Continuing from here 👉 #45

   Something I can imagine would be nice, if you make a selection of multiple changed lines and then you hover the gutter and click on the ✅ to stage, all selected lines would be staged.

   Maybe we can 👖 next week? Or I can make a couple more screens that show it step by step.
9. joshaber commented on Mar 14, 2016

   

   joshaber

   on Mar 14, 2016

   ContributorAuthor

   More actions

   Maybe we can 👖 next week?

   Yeah, that'd be great. I'm first responder this week, so maybe the next week?

   👍React with 👍1Reacted by simurai
10. joshaber

    assigned

    kuychaco

    on Mar 21, 2016
11. kuychaco

    modified the milestones: 3: MVP Public Release, 2: Committing from a selection / committing editor integration on Sep 10, 2016
12. kuychaco

    closed this as completedin #879on May 30, 2017