You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
As far as implementation goes, I'm wondering how this would actually work. Would we essentially re-implement git-diff and suppress its styling? Or provide new functionality to git-diff somehow?
@atom/core I could use some Informed Opinions here.
I'm concerned about relying too much on color distinctions for UI like this. Estimates are 4-5% of the population has some form of colorblindness. I know that we don't really want to crowd the gutter, but I think an additional symbol of some sort would be better.
After mulling this, I think we should 👢 it from this milestone. This seems like a nice integration to have, but I think there are more important things we should do first.
@lee-dohm but I think an additional symbol of some sort would be better.
In the diff view, there is the idea of another column with checkmarks if something is staged. Could be added to the gutter too.
But yeah, it adds extra clutter. Maybe it could be toggled in the settings too, like the git border vs icons.
Anyways, @joshaber yeah, 👍 on 👢ing this from the current milestone. I think there is some potential in getting git closer into the editor, but things like creating/switching branches or pull/push feel more essential for now.
As far as implementation goes, I'm wondering how this would actually work. Would we essentially re-implement git-diff and suppress its styling?
I have a WIP implementation of the git-diff functionality inside atom/github using the git-shellout-strategy.
This was primarily done to investigate new possibilities of improving the performance of git-diff when using network mounted volumes (e.g. using sshfs). Since git-diff relies on synchronous git calls, Atom is almost unusable with git repos mounted over WIFI.
But this approach would also allow a fairly easy way of adding stagedness status in the editor gutter. @joshaber Are you interested in a PR illustrating this approach in more detail?
The code is located here. I'm happy to flesh this out a bit more and make a PR that explains it in detail if there is general interest in this approach.
Activity
joshaber commentedon Feb 26, 2016
@simurai I couldn't find any wireframes for this.
simurai commentedon Feb 27, 2016
We were thinking about overriding the color of the git-lines.
And when you enable "Show Icons In Editor Gutter" in the
git-diffpackage (with dark theme):Currently these classes get used:
.git-line-removed.git-line-modified.git-line-addedSo lines that are staged could get an additional
.git-line-stagedclass?joshaber commentedon Mar 23, 2016
As far as implementation goes, I'm wondering how this would actually work. Would we essentially re-implement
git-diffand suppress its styling? Or provide new functionality togit-diffsomehow?@atom/core I could use some Informed Opinions here.
lee-dohm commentedon Mar 23, 2016
I'm concerned about relying too much on color distinctions for UI like this. Estimates are 4-5% of the population has some form of colorblindness. I know that we don't really want to crowd the gutter, but I think an additional symbol of some sort would be better.
joshaber commentedon Mar 23, 2016
After mulling this, I think we should 👢 it from this milestone. This seems like a nice integration to have, but I think there are more important things we should do first.
@simurai Thoughts?
simurai commentedon Mar 24, 2016
In the diff view, there is the idea of another column with checkmarks if something is staged. Could be added to the gutter too.
But yeah, it adds extra clutter. Maybe it could be toggled in the settings too, like the git border vs icons.
Anyways, @joshaber yeah, 👍 on 👢ing this from the current milestone. I think there is some potential in getting git closer into the editor, but things like creating/switching branches or pull/push feel more essential for now.
lgeiger commentedon Jan 18, 2018
I have a WIP implementation of the
git-difffunctionality insideatom/githubusing the git-shellout-strategy.This was primarily done to investigate new possibilities of improving the performance of
git-diffwhen using network mounted volumes (e.g. using sshfs). Sincegit-diffrelies on synchronous git calls, Atom is almost unusable with git repos mounted over WIFI.But this approach would also allow a fairly easy way of adding stagedness status in the editor gutter.
@joshaber Are you interested in a PR illustrating this approach in more detail?
simurai commentedon Jan 19, 2018
FYI @joshaber isn't on this team anymore. 😢
/cc @kuychaco @smashwilson
lgeiger commentedon Jan 23, 2018
The code is located here. I'm happy to flesh this out a bit more and make a PR that explains it in detail if there is general interest in this approach.
annthurium commentedon Oct 2, 2018
we have the git diff package that has this functionality now - going to close this out.