This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Clicking on large files with many modification in Git panel freezes Atom. #1968
Description
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
Clicking on large files with many diffs (f.e. a JavaScript bundle file generated by Webpack) in the Git panel freezes Atom. It's even more annoying when somehow the file gets selected as the default selection when I open the panel, then I have to restart Atom. :(
Steps to Reproduce
- add a big Webpack bundle to git repo.
- make changes that produce a large diff.
- click on it in the Git panel
Expected behavior:
no crash
Actual behavior:
crash
Reproduces how often:
100%
Versions
debug info with package info
{
"atom": "1.34.0",
"platform": "win32",
"release": "10.0.17763",
"vmpVersion": "1.36.0",
"vmpConfig": {},
"activeCommunityPackages": [
"atom-material-syntax: 1.0.8",
"aligner-javascript: 1.3.0",
"atom-ide-ui: 0.13.0",
"atom-ide-busy-signal: 0.0.0",
"atom-ide-code-actions: 0.0.0",
"atom-ide-code-format: 0.0.0",
"atom-ide-code-highlight: 0.0.0",
"atom-ide-console: 0.0.0",
"atom-ide-datatip: 0.0.0",
"atom-ide-debugger: 0.0.0",
"atom-ide-definitions: 0.0.0",
"atom-ide-diagnostics: 0.0.0",
"atom-ide-diagnostics-ui: 0.0.0",
"atom-ide-find-references: 0.0.0",
"atom-ide-global: 0.0.0",
"atom-ide-outline-view: 0.0.0",
"atom-ide-refactor: 0.0.0",
"atom-ide-signature-help: 0.0.0",
"atom-ide-terminal: 0.0.0",
"hyperclick: 0.0.0",
"atom-vim-like-tab: 1.5.1",
"autocomplete-modules: 2.2.2",
"autocomplete-paths: 2.12.2",
"better-git-blame: 0.4.7",
"busy-signal: 1.4.3",
"docblockr: 0.13.7",
"emmet: 2.4.3",
"ex-mode-sort: 1.0.0",
"file-icons: 2.1.21",
"file-watcher: 1.2.6",
"git-plus: 8.1.0",
"hey-pane: 1.1.0",
"highlight-line: 0.12.0",
"highlight-selected: 0.13.1",
"imdone-atom: 2.4.29",
"indent-guide-improved: 1.4.13",
"intentions: 1.1.5",
"keystroke: 0.4.0",
"minimap: 4.29.8",
"minimap-find-and-replace: 4.5.2",
"minimap-git-diff: 4.3.1",
"minimap-highlight-selected: 4.6.1",
"minimap-linter: 2.2.1",
"minimap-pigments: 0.2.2",
"minimap-quick-highlight: 1.0.1",
"pigments: 0.40.2",
"prettier-atom: 0.56.2",
"project-plus: 1.0.0",
"quick-highlight: 0.13.0",
"split-diff: 1.4.0",
"teletype: 0.13.2",
"todo-show: 2.3.0",
"tree-view-git-status: 1.5.0",
"vim-mode-plus: 1.36.0",
"vim-mode-plus-keymaps-for-surround: 0.2.1",
"language-jenkinsfile: 0.1.1",
"language-javascript-jsx: 0.3.7",
"language-pug: 0.0.22",
"editorconfig: 2.2.2",
"language-vue: 0.23.1",
"termination: 0.7.1"
]
}
Activity
trusktr commentedon Feb 20, 2019
The diff that freezes Atom (because I think that's the problem) is 67000 lines long.
rsese commentedon Feb 20, 2019
Thanks for the report @trusktr! I believe we've been closing similar reports as a duplicate of #1759 if you want to subscribe there for updates.
trusktr commentedon Apr 20, 2019
@rsese Hello! Atom 1.36.0 works much better with big diffs now. Thanks!
I found that it still may take long to load certain big diffs like the following: https://gist.github.com/trusktr/175c7b1402c960daed3e022fdc1d79fe