This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Re-introduce the "large diff" gate #1759
Description
With #1512, we can now handle much larger diffs without causing the same UI lockups that we observed previously. It isn't infinite, though, so there is likely still some diff size where we should make users click through a confirmation before trying to render a patch.
Metadata
Metadata
Assignees
Labels
No labels
Activity
annthurium commentedon Oct 29, 2018
@vanessayuenn are you working on this? If so would you mind assigning it to yourself?
paul-arthurthiery commentedon Mar 29, 2019
hey @vanessayuenn @annthurium would it be possible to update the status on this ? it's ongoing on a closed board so... is it ongoing or dropped ? I'm waiting impatiently for this issue to be fixed 😁
annthurium commentedon Mar 29, 2019
@paul-arthurthiery we shipped the large diff gate feature in Atom 1.36 Beta, which was released the second week of March. Check it out, let us know what you think! 😄
Beta rolls over into stable in next month's release, so if you don't feel like dealing with Atom Beta, you should be able to use the feature sometime in April.
Let me know if you have any other questions
rsese commentedon Apr 22, 2019
Helllooo! Based on Ash's comment above:
And from #1968 (comment) (/cc @trusktr):
Sounds like slowdown is still expected for some super large diffs and there's potential followup work to have people click through to see these large diffs?