Repository navigation
Remove input schema from PhysicalExpr, move the validation logic to physical expression planner - #6122
Merged
Conversation
…hyiscal expression planner
Contributor
Author
crepererum
approved these changes
Apr 26, 2023
crepererum
left a comment
Contributor
There was a problem hiding this comment.
This is sooo much cleaner, thank you!
alamb
approved these changes
Apr 26, 2023
Contributor
There was a problem hiding this comment.
This looks great to me -- thank you @mingmwang
cc @crepererum I think @mingmwang has fixed the root cause of the inlist discrepancy you fixed in #6114
Update: I didn't see @crepererum beat me to this review
| lhs: Arc<dyn PhysicalExpr>, | ||
| op: Operator, | ||
| rhs: Arc<dyn PhysicalExpr>, | ||
| // TODO: move type checking to the planning phase and not in the physical expr |
|
|
||
| /// Creates a `Box<dyn Set>` for the given list of `IN` expressions and `batch` | ||
| fn make_set(array: &dyn Array) -> Result<Box<dyn Set>> { | ||
| fn make_set(array: &dyn Array) -> Result<Arc<dyn Set>> { |
Contributor
There was a problem hiding this comment.
This is a clever idea -- to avoid cloning the set over and over again 👍
| column.name(), | ||
| index, | ||
| )))); | ||
| } else if let Some(in_list) = expr_any.downcast_ref::<InListExpr>() { |
| } | ||
|
|
||
| /// create a DateIntervalExpr | ||
| pub fn date_time_interval_expr( |
Contributor
There was a problem hiding this comment.
👍 this also follows the model of the other creation functions in physical expr.
| }; | ||
| pub use column::{col, Column, UnKnownColumn}; | ||
| pub use datetime::DateTimeIntervalExpr; | ||
| pub use datetime::{date_time_interval_expr, DateTimeIntervalExpr}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6117.
Rationale for this change
FollowUp after #6114
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?