Repository navigation
fix: reassign_predicate_columns w/ in-list expr - #6114
Conversation
We need to also re-assign the schema stored within `InListExpr` at the same time when we replace the children.
|
LGTM |
|
It is unrelated to this PR, but I think the original implementation of the |
|
There are some other physical Exprs which might be schema aware. |
|
I think we should remove the input schema from those phyiscal Exprs, and move the type check in the physical expression planner. |
|
My bad, looks like the I will file a FOLLOWUP ticket to remove the input_schema in this and other physical exprs and move the validation logic to the physical expression planner. So that you do not need a specific handling on InListExpr to re-assign a schema. |
|
Thank you @crepererum and @mingmwang |
Which issue does this PR close?
Related to upstream ticket https://github.com/influxdata/influxdb_iox/issues/7644
Rationale for this change
We need to also re-assign the schema stored within
InListExprat the same time when we replace the children.This bug affects both the public API
reassign_predicate_columnsas well as potential internal use of it.What changes are included in this PR?
Bugfix.
Are these changes tested?
New test.
Are there any user-facing changes?
-