Skip to content

Merge s3_success and s3_build_error tests into one test - #3602

Merged
tustvold merged 1 commit into
apache:masterfrom
Licht-T:make-s3-tests-serial
Sep 24, 2022
Merged

tustvold merged 1 commit into
apache:masterfrom
Licht-T:make-s3-tests-serial

Conversation

@Licht-T

@Licht-T Licht-T commented Sep 24, 2022 •

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #3601

Rationale for this change

Fixing fragile tests

What changes are included in this PR?

  • Merge s3_build_error and s3_success into one test

Are there any user-facing changes?

No.

Comment thread datafusion-cli/Cargo.toml Outdated
url = "2.2"

[dev-dependencies]
serial_test = "*"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than a new dependency, could we just merge them into a single test?

@Licht-T Licht-T Sep 24, 2022 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, yes. As per your recommendation, I merged two tests into one.

@Licht-T
Licht-T force-pushed the make-s3-tests-serial branch from b136466 to 995feab Compare September 24, 2022 09:58
@Licht-T Licht-T changed the title Make s3_success and s3_build_error tests serial Merge s3_success and s3_build_error tests into one test Sep 24, 2022
@tustvold
tustvold merged commit 8bcc965 into apache:master Sep 24, 2022
@tustvold

Copy link
Copy Markdown
Contributor

Thank you

@ursabot

ursabot commented Sep 24, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 0b204c6 and contender = 8bcc965. 8bcc965 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

s3_build_error test may fail in some environments

3 participants