Skip to content

s3_build_error test may fail in some environments #3601

Closed

Description

@Licht-T

Describe the bug
Regarding #3540, s3_build_error test fails in some environments. This test may run while s3_success test sets AWS_DEFAULT_REGION environmental variable.

To Reproduce
Run tests in Ubuntu 22.04.

[datafusion-cli] cargo test
   Compiling datafusion-cli v12.0.0 (/home/rito/arrow-datafusion/datafusion-cli)
    Finished test [unoptimized + debuginfo] target(s) in 12.27s
     Running unittests src/lib.rs (target/debug/deps/datafusion_cli-11f57697bc6719fd)

running 7 tests
test object_storage::tests::gcs_provider_no_host ... ok
test object_storage::tests::s3_provider_no_host ... ok
test object_storage::tests::unknown_object_store_type ... ok
test print_format::tests::test_print_batches_with_sep ... ok
test print_format::tests::test_print_batches_to_json_empty ... ok
test object_storage::tests::s3_success ... ok
test object_storage::tests::s3_build_error ... FAILED

failures:

---- object_storage::tests::s3_build_error stdout ----
thread 'object_storage::tests::s3_build_error' panicked at 'called `Result::unwrap_err()` on an `Ok` value: AmazonS3 { client: S3Client { config: S3Config { region: "us-east-1", endpoint: "https://s3.us-east-1.amazonaws.com", bucket: "bucket_name", credentials: Instance(InstanceCredentialProvider { cache: TokenCache { cache: Mutex { data: None } }, client: Client { accepts: Accepts, proxies: [Proxy(System({}), None)], referer: true, default_headers: {"accept": "*/*"} }, retry_config: RetryConfig { backoff: BackoffConfig { init_backoff: 100ms, max_backoff: 15s, base: 2.0 }, max_retries: 10, retry_timeout: 180s }, imdsv1_fallback: false }), retry_config: RetryConfig { backoff: BackoffConfig { init_backoff: 100ms, max_backoff: 15s, base: 2.0 }, max_retries: 10, retry_timeout: 180s }, allow_http: false }, client: Client { accepts: Accepts, proxies: [Proxy(System({}), None)], referer: true, default_headers: {"accept": "*/*"} } } }', src/object_storage.rs:138:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    object_storage::tests::s3_build_error

test result: FAILED. 6 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Expected behavior
All tests pass.

Additional context
N/A

Activity

  1. changed the title [-]`s3_build_error` test fails[/-] [+]`s3_build_error` test may fail in some environments[/+] on Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions