Repository navigation
Add support for ORDER BY on unprojected columns - #1415
Merged
Merged
Conversation
Member
|
It'll be better to also add a test in |
xudong963
reviewed
Dec 8, 2021
viirya
commented
Dec 8, 2021
Member
Author
|
Thanks @xudong963 |
houqp
reviewed
Dec 8, 2021
Member
|
Thank you @viirya , very cool to see this in action. |
Member
Author
|
@houqp thanks for review. Fixed. |
xudong963
approved these changes
Dec 8, 2021
| Ok(()) | ||
| })?; | ||
|
|
||
| if missing_cols.is_empty() { |
Contributor
|
Thanks @viirya ! |
Contributor
|
Nice 🎉 |
alamb
reviewed
Dec 9, 2021
| let mut ctx = ExecutionContext::new(); | ||
| register_alltypes_parquet(&mut ctx).await; | ||
| // execute the query | ||
| let sql = "SELECT id FROM alltypes_plain ORDER BY int_col, double_col"; |
Member
Author
|
Thank you @houqp @xudong963 @alamb @Dandandan ! |
Merged
ORDER BY on unprojected columns
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
…ceberg_compat readers (apache#1415) major changes : - allow Uint64 to decimal and FixedWidthBinary to Binary conversions in complex readers - do not enable prefetch reads in tests if complex reader is enabled - fix more incompatible checks in uint_8/uint_16 tests - skip datetime rebase tests for complex readers (not supported) There may be conflicts between this and apache#1413 (@mbutrovich) which removes the `cast_supported` method but can be reconciled afterwards Without apache#1413 the failure counts are: ``` native_datafusion: Tests: succeeded 658, failed 19, canceled 4, ignored 54, pending 0 native_iceberg_compat: Tests: succeeded 662, failed 15, canceled 4, ignored 54, pending 0 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1372.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?