Skip to content

fix: Select * returns an unexpected result - #1413

Merged
alamb merged 1 commit into
apache:masterfrom
xudong963:fix_wild
Dec 9, 2021
Merged

alamb merged 1 commit into
apache:masterfrom
xudong963:fix_wild

Conversation

@xudong963

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #1412

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added datafusion sql SQL Planner labels Dec 7, 2021
@xudong963
xudong963 force-pushed the fix_wild branch 2 times, most recently from 59d5f1c to e7eb238 Compare December 7, 2021 16:17
@houqp houqp added the bug Something isn't working label Dec 8, 2021
@xudong963
xudong963 requested a review from houqp December 9, 2021 15:48

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good find @xudong963 👍

@alamb
alamb merged commit 755786b into apache:master Dec 9, 2021
@xudong963
xudong963 deleted the fix_wild branch December 9, 2021 18:01
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
…al native scans (apache#1413)

* Remove more cast-related logic from schema_adapter.rs.

* Fix warning for unused variable.
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
…ceberg_compat readers (apache#1415)

major changes :
- allow Uint64 to decimal and  FixedWidthBinary to Binary conversions in complex readers
- do not enable prefetch reads in tests if complex reader is enabled
- fix more incompatible checks in uint_8/uint_16 tests
- skip datetime rebase tests for complex readers (not supported)

There may be conflicts between this and apache#1413  (@mbutrovich) which removes the `cast_supported` method but can be reconciled afterwards

Without apache#1413 the failure counts are: 
```
native_datafusion: Tests: succeeded 658, failed 19, canceled 4, ignored 54, pending 0
native_iceberg_compat: Tests: succeeded 662, failed 15, canceled 4, ignored 54, pending 0
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select * returns an unexpected result

3 participants