Skip to content

UI: fix missing networkid and zoneid when add instance from vpc network - #7151

Merged
weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-ui-fix-create-vm-from-vpc
Feb 1, 2023
Merged

weizhouapache merged 1 commit into
apache:4.17from
weizhouapache:4.17-ui-fix-create-vm-from-vpc

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes an UI bug that zoneid/networkid is missing when add a instance from vpc network.

This is a regression of vue3 upgrade.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7151 (QA-JID-38)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

tested in qa, bug fixed

@codecov

codecov Bot commented Jan 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #7151 (a470274) into 4.17 (ca7e1ac) will decrease coverage by 0.95%.
The diff coverage is 23.23%.

@@             Coverage Diff              @@
##               4.17    #7151      +/-   ##
============================================
- Coverage     11.31%   10.37%   -0.95%     
+ Complexity     7334     6647     -687     
============================================
  Files          2494     2453      -41     
  Lines        246787   242437    -4350     
  Branches      38533    37938     -595     
============================================
- Hits          27933    25151    -2782     
+ Misses       215255   214177    -1078     
+ Partials       3599     3109     -490     
Impacted Files Coverage Δ
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java 28.43% <0.00%> (-0.47%) ⬇️
...main/java/com/cloud/service/ServiceOfferingVO.java 38.84% <0.00%> (+2.15%) ⬆️
.../actionworkers/KubernetesClusterDestroyWorker.java 0.00% <0.00%> (ø)
.../apache/cloudstack/metrics/MetricsServiceImpl.java 14.94% <0.00%> (ø)
.../apache/cloudstack/response/DbMetricsResponse.java 0.00% <ø> (ø)
...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java 3.26% <0.00%> (ø)
...src/main/java/com/cloud/api/ApiResponseHelper.java 2.46% <0.00%> (-1.42%) ⬇️
.../cloud/configuration/ConfigurationManagerImpl.java 10.84% <0.00%> (-1.65%) ⬇️
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 0.00% <0.00%> (ø)
.../main/java/com/cloud/network/NetworkModelImpl.java 9.92% <0.00%> (-1.31%) ⬇️
... and 355 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephankruggg stephankruggg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@weizhouapache
weizhouapache merged commit bcf5ff1 into apache:4.17 Feb 1, 2023
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Feb 1, 2023
DaanHoogland added a commit that referenced this pull request Feb 1, 2023
* 4.17:
  server: add/update user vm details for new root disk size (issue 7139) (#7145)
  UI: fix missing networkid and zoneid when add instance from vpc network (#7151)
@weizhouapache
weizhouapache deleted the 4.17-ui-fix-create-vm-from-vpc branch February 13, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants