Repository navigation
UI: fix missing networkid and zoneid when add instance from vpc network - #7151
Merged
weizhouapache merged 1 commit intoFeb 1, 2023
Merged
Conversation
Member
Author
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
|
tested in qa, bug fixed |
Codecov Report
@@ Coverage Diff @@
## 4.17 #7151 +/- ##
============================================
- Coverage 11.31% 10.37% -0.95%
+ Complexity 7334 6647 -687
============================================
Files 2494 2453 -41
Lines 246787 242437 -4350
Branches 38533 37938 -595
============================================
- Hits 27933 25151 -2782
+ Misses 215255 214177 -1078
+ Partials 3599 3109 -490
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an UI bug that zoneid/networkid is missing when add a instance from vpc network.
This is a regression of vue3 upgrade.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?