server: add/update user vm details for new root disk size (issue 7139)

[weizhouapache]

Description

This PR fixes two issues including #7139

(1) if vm is created with specific rootdisksize, resize datadisk will update the user vm details for rootdisksize
(2) if vm is not created with specific rootdisksize, resize rootdisk will not add user vm details for new rootdisksize, which causes #7139

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

(1) create vm with root disk size=10 GB, datadisk =5 GB, check user_vm_details

| 4129 |   433 | rootdisksize          | 10    |       1 |

Prior to this change, when resize data disk to 6GB

| 4133 |   433 | rootdisksize                       | 6     |       1 |

with this change, detail is NOT changed when resize data disk.

(2) create vm without specific root disk size. resize root disk to 11GB,

Prior to this change, there is NO details for new root disk size

with this change,

| 4136 |   432 | rootdisksize                       | 11    |       1 |

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5444

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[soreana]

@weizhouapache Thanks Wei,

I'm testing the PR. 👍

[soreana]

@weizhouapache Manually tested the PR, it works as expected.

[DaanHoogland]

clgtm

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-6036)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39974 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7145-t6036-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	597.69	test_kubernetes_clusters.py

[weizhouapache]

merging based on @DaanHoogland's review and @soreana 's manual testing

the smoke test failure is not related. which has been fixed by #7118 in main branch (but not in 4.17)