Skip to content

CI: run the initdb TAP test - #2238

Open
tuhaihe wants to merge 3 commits into
apache:mainfrom
tuhaihe:fix-initdb-pax-rmgr-log
Open

tuhaihe wants to merge 3 commits into
apache:mainfrom
tuhaihe:fix-initdb-pax-rmgr-log

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Nov 4, 2026

Copy link
Copy Markdown
Member

#2229 fixed src/bin/initdb/t/001_initdb.pl after the REL_16_9 merge, but CI does not run this test, so the next break can go unnoticed.

Add an ic-initdb test job that runs it on Rocky 8, 9 and 10.

Assisted-by: Claude Code

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


apache#2229 fixed src/bin/initdb/t/001_initdb.pl after the REL_16_9 merge,
but CI does not run this test, so the next break can go unnoticed.

Add an ic-initdb test job that runs it on Rocky 8, 9 and 10.

Assisted-by: Claude Code
@tuhaihe
tuhaihe requested a review from Vlasdislav November 4, 2026 07:44
@tuhaihe

tuhaihe commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Error:

echo "# +++ tap install-check in src/bin/initdb +++" && rm -rf '/__w/cloudberry/cloudberry/src/bin/initdb'/tmp_check && /usr/bin/mkdir -p '/__w/cloudberry/cloudberry/src/bin/initdb'/tmp_check && cd . && TESTLOGDIR='/__w/cloudberry/cloudberry/src/bin/initdb/tmp_check/log' TESTDATADIR='/__w/cloudberry/cloudberry/src/bin/initdb/tmp_check' PATH="/usr/local/cloudberry-db/bin:/__w/cloudberry/cloudberry/src/bin/initdb:$PATH" PGPORT='65432' top_builddir='/__w/cloudberry/cloudberry/src/bin/initdb/../../..' PG_REGRESS='/__w/cloudberry/cloudberry/src/bin/initdb/../../../src/test/regress/pg_regress' /usr/bin/prove -I ../../../src/test/perl/ -I .  t/*.pl
# +++ tap install-check in src/bin/initdb +++

#   Failed test 'options --locale-provider=icu --locale=und --lc-*=C: no stderr'
#   at t/001_initdb.pl line 124.
#          got: '2026-11-04 00:04:34.209813 PST,,,p8569,th-1597855552,,,,0,,,seg-10000,,,,,"LOG","00000","registered custom resource manager ""Pax resource manager"" with ID 199",,,,,,,,"RegisterCustomRmgr","rmgr.c",139,
# '
#     expected: ''
# Looks like you failed 1 test of 45.
t/001_initdb.pl .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/45 subtests 

Let us append one commit to fix the failed test.

@tuhaihe tuhaihe moved this to In Progress in Merge postgres 16 Nov 4, 2026
With --enable-pax, every backend loads pax through the built-in list in
utils/process_shared_preload_libraries.h.  pax registers a custom
resource manager, and RegisterCustomRmgr() reports this at LOG.  A
single-user backend writes LOG messages to stderr, so each initdb run
prints this during post-bootstrap initialization:

  performing post-bootstrap initialization ... <time>,...,"LOG",
  "00000","registered custom resource manager ""Pax resource manager""
  with ID 199",...

The initdb TAP test expects one initdb run to write nothing to stderr,
so the test fails on each build with pax, which includes the CI build.

Report the message at DEBUG1 when there is no postmaster.  A postmaster
still reports it at LOG.

Assisted-by: Claude Code
@tuhaihe

tuhaihe commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Note: This separate PR addresses the failing test and is easy to review; once fixed, I’ll consolidate the similar tests into one.

The comments that the earlier commits of this change added name the
project as "GPDB".  Use "Cloudberry" instead.  Only comments change.

Assisted-by: Claude Code

@leborchuk leborchuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants