Repository navigation
initdb: fix TAP test after REL_16_9 merge - #2229
Merged
Merged
Conversation
chenjinbao1989
force-pushed
the
fix-initdb-tap-test
branch
from
November 3, 2026 02:10
b0283d8 to
ec9481c
Compare
reshke
approved these changes
Nov 3, 2026
Collaborator
|
I don't see run test {"test":"ic-initdb",
"make_configs":["src/bin/initdb:installcheck"]
},To see what has changed |
Member
Good idea. I will try to add other similar tests to our daily CI workflow. |
13 tasks
yjhjstz
approved these changes
Nov 4, 2026
yjhjstz
enabled auto-merge (rebase)
November 4, 2026 04:51
The merge left 001_initdb.pl importing the legacy PostgresNode and TestLib modules, which it does not use. PostgresNode.pm still loads PostgresVersion, which the merge moved to PostgreSQL/Version.pm, so the test failed to compile. It also kept a fixed plan of 22 + 2 tests while the upstream body ends with done_testing() and runs 45 tests. Drop the unused imports and the fixed plan, matching upstream.
yjhjstz
force-pushed
the
fix-initdb-tap-test
branch
from
November 4, 2026 04:51
ec9481c to
da3b67d
Compare
tuhaihe
added a commit
to tuhaihe/cloudberrydb
that referenced
this pull request
Nov 4, 2026
configure-cloudberry.sh builds with --enable-tap-tests, but CI runs TAP tests only in src/test/recovery. The other TAP suites, and the suites in src/pl and src/test/modules, do not run at all, so nobody sees when they break. For example, the REL_16_9 merge broke the initdb TAP test (apache#2229). Add two test jobs with the suites that pass without changes on Rocky 8, 9 and 10: - ic-tap: the TAP suites of pg_archivecleanup, pg_config, pg_controldata, pg_resetwal, pg_waldump, libpq and the postmaster, and of the ssl_passphrase_callback and test_custom_rmgrs modules. - ic-pl-modules: PL/Perl and twelve regression suites in src/test/modules. The build does not install src/test/modules, so those entries run "install installcheck". The test steps joined make_configs with spaces and then split the result on spaces, so such an entry became two configurations. Join the entries with newlines and read one entry per line instead. All other entries give the same configurations as before. The other suites fail now. We will add them after we fix them in separate changes. Assisted-by: Claude Code
tuhaihe
added a commit
to tuhaihe/cloudberrydb
that referenced
this pull request
Nov 4, 2026
apache#2229 fixed src/bin/initdb/t/001_initdb.pl after the REL_16_9 merge, but CI does not run this test, so the next break can go unnoticed. Add an ic-initdb test job that runs it on Rocky 8, 9 and 10. Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge left 001_initdb.pl importing the legacy PostgresNode and TestLib modules, which it does not use. PostgresNode.pm still loads PostgresVersion, which the merge moved to PostgreSQL/Version.pm, so the test failed to compile. It also kept a fixed plan of 22 + 2 tests while the upstream body ends with done_testing() and runs 45 tests.
Drop the unused imports and the fixed plan, matching upstream.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions