Skip to content

GH-46333: [CI] Always pass --yes to mamba clean - #46341

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:mamba-clean
May 7, 2025
Merged

pitrou merged 1 commit into
apache:mainfrom
pitrou:mamba-clean

Conversation

@pitrou

@pitrou pitrou commented May 7, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

Some CI builds can get stuck before mamba clean is asking for confirmation. See example here:
https://github.com/apache/arrow/actions/runs/14855669693/job/41708331720?pr=46332

This might depend on the Mamba version and whether it implements TTY detection reliably.

What changes are included in this PR?

Always pass --yes to mamba clean.

Are these changes tested?

Yes, by definition.

Are there any user-facing changes?

No.

@pitrou

pitrou commented May 7, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-conda-*

@github-actions github-actions Bot added the awaiting review Awaiting review label May 7, 2025
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown

Revision: d416610

Submitted crossbow builds: ursacomputing/crossbow @ actions-d765f8e54e

Task Status
test-conda-cpp GitHub Actions
test-conda-cpp-meson GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions

@pitrou pitrou changed the title MINOR: [CI] Always pass --yes to mamba clean GH-46333: [CI] Always pass --yes to mamba clean May 7, 2025
@pitrou

pitrou commented May 7, 2025

Copy link
Copy Markdown
Member Author

For some reason, PR #46334 only fixed the integration build. @kou @lidavidm

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I only looked at integration since originally I only noticed it when it was failing PRs on arrow-java; I didn't check the other dockerfiles

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 7, 2025
@pitrou
pitrou marked this pull request as ready for review May 7, 2025 07:52
@pitrou

pitrou commented May 7, 2025

Copy link
Copy Markdown
Member Author

Wow, lots of unrelated failures here.

@pitrou
pitrou merged commit ef3b0ef into apache:main May 7, 2025
@pitrou pitrou removed the awaiting merge Awaiting merge label May 7, 2025
@pitrou
pitrou deleted the mamba-clean branch May 7, 2025 08:14
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ef3b0ef.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants