Skip to content

GH-46333: [CI] Explicitly pass --yes to mamba clean - #46334

Merged
kou merged 1 commit into
apache:mainfrom
lidavidm:gh-46333
May 6, 2025
Merged

kou merged 1 commit into
apache:mainfrom
lidavidm:gh-46333

Conversation

@lidavidm

@lidavidm lidavidm commented May 6, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

CI is broken across multiple Arrow repos.

What changes are included in this PR?

Explicitly pass --yes to mamba clean.

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@lidavidm lidavidm changed the title GH-46333: [CI] Explicitly pass --yes to mamba clean GH-46333: [CI] Explicitly pass --yes to mamba clean May 6, 2025
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label May 6, 2025
@lidavidm lidavidm mentioned this pull request May 6, 2025
5 tasks done
@lidavidm

lidavidm commented May 6, 2025

Copy link
Copy Markdown
Member Author

I had a quick look but didn't seem to find any obvious commit/change that might've caused this on mamba's end

@lidavidm
lidavidm marked this pull request as ready for review May 6, 2025 10:54

@raulcd raulcd left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has also started failing on my PR, along with the other CI failure which is unrelated (test_gdb.py) which seems to fail only on that Python job.

Assuming CI successful on the integration job

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 6, 2025
@lidavidm

lidavidm commented May 6, 2025

Copy link
Copy Markdown
Member Author

Looks like integration now passes here

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit f270643 into apache:main May 6, 2025
@kou kou removed the awaiting merge Awaiting merge label May 6, 2025
@github-actions github-actions Bot added the awaiting merge Awaiting merge label May 6, 2025
@lidavidm
lidavidm deleted the gh-46333 branch May 6, 2025 12:27
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f270643.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants