Repository navigation
GH-45877: [C++][Acero] Cleanup 64-bit temp states of Swiss join by using 32-bit - #45878
Merged
zanmato1984 merged 2 commits intoMar 24, 2025
Merged
Conversation
zanmato1984
force-pushed
the
reduce-swiss-join-thread-state
branch
3 times, most recently
from
March 21, 2025 09:46
f311142 to
b53bd36
Compare
Contributor
Author
|
@github-actions crossbow submit -g cpp |
Contributor
Author
|
Revision: b53bd36e92a6b11500dcc821a95407aef0eb2598 Submitted crossbow builds: ursacomputing/crossbow @ actions-3e7a3282e6
|
zanmato1984
force-pushed
the
reduce-swiss-join-thread-state
branch
from
March 21, 2025 10:19
f9b37fc to
7033df9
Compare
Contributor
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 7033df9 Submitted crossbow builds: ursacomputing/crossbow @ actions-6da124e9bf
|
Contributor
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 16c26dc Submitted crossbow builds: ursacomputing/crossbow @ actions-48f12825c2
|
github-actions
Bot
added
awaiting merge
Contributor
Author
|
Thank you @kou for reviewing. I'm merging this. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ea0b3c5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
zanmato1984
added a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
… by using 32-bit (apache#45878) ### Rationale for this change See apache#45877. ### What changes are included in this PR? 1. Normalize all temp states/variables representing "row id"s to `uint32_t`. 2. Cleanup many `DCHECK`s (some added though) and `static_cast`s. ### Are these changes tested? Existing tests should suffice. ### Are there any user-facing changes? None. * GitHub Issue: apache#45877 Authored-by: Rossi Sun <zanmato1984@gmail.com> Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #45877.
What changes are included in this PR?
uint32_t.DCHECKs (some added though) andstatic_casts.Are these changes tested?
Existing tests should suffice.
Are there any user-facing changes?
None.