Skip to content

[C++][Acero] Cleanup 64-bit temp states of Swiss join by using 32-bit #45877

Closed

Description

@zanmato1984

Describe the enhancement requested

Since we have already addressed almost all potential overflow issues of Swiss join by #45336, #45515, we are now quite positive that:

  1. The limit of number of rows in a Swiss table is uint32_max.
  2. Any computation on "row id" that is possible of overflow has been properly handled to prevent overflow from happening.

It's time to finally cleanup the temp states remaining unnecessarily to be 64-bit to tolerant certain overflow, e.g. #45336 (comment).

Component(s)

C++

Activity

  1. self-assigned this
    on Mar 21, 2025
  2. added a commit that references this issue on Mar 24, 2025
  3. added this to the 20.0.0 milestone on Mar 24, 2025
  4. zanmato1984 commented on Mar 24, 2025

    @zanmato1984
    ContributorAuthor

    Issue resolved by pull request 45878
    #45878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions