Repository navigation
GH-45589: [C++] Enable singular test in Meson configuration - #45596
Conversation
|
|
There was a problem hiding this comment.
The static_library is required here because the Meson wrap dependency for gtest only provides consumers with the source files, and when using that in two different shared libraries then linking together you get an ODR violation.
See also mesonbuild/wrapdb#1937
There was a problem hiding this comment.
This is to follow along with the CMake configuration. The option doesn't yet exist in Meson so I've hard-coded for now
There was a problem hiding this comment.
| meson setup \ | |
| --prefix=${MESON_PREFIX:-${ARROW_HOME}} \ | |
| --buildtype=${ARROW_BUILD_TYPE:-debug} \ | |
| -Dtests=true \ | |
| function meson_boolean() { | |
| if [ "${1}" = "ON" ]; then | |
| echo "true" | |
| else | |
| echo "false" | |
| fi | |
| } | |
| meson setup \ | |
| --prefix=${MESON_PREFIX:-${ARROW_HOME}} \ | |
| --buildtype=${ARROW_BUILD_TYPE:-debug} \ | |
| -Dtests=$(meson_boolean ${ARROW_BUILD_TESTS:-OFF}) \ |
There was a problem hiding this comment.
| subprojects/* | |
| !subprojects/packagefiles | |
| !subprojects/*.wrap | |
| /subprojects/* | |
| !/subprojects/packagefiles | |
| !/subprojects/*.wrap |
|
@github-actions crossbow submit test-conda-cpp-meson |
|
Revision: 65779fa641362cc3e960133fa51e7ce928afa620 Submitted crossbow builds: ursacomputing/crossbow @ actions-b0685743f1
|
|
https://github.com/ursacomputing/crossbow/actions/runs/13468923214/job/37639840316#step:6:448 Hmm. It's strange that RapidJSON wasn't found. RapidJSON exists in the environment: https://github.com/ursacomputing/crossbow/actions/runs/13468923214/job/37639840316#step:6:351 |
|
Sorry I've been away for a few days.
In spite of Meson not finding the system RapidJSON, it does still fall back to using the wrap file to download an appropriate copy. Seems like the error message from that run has to do with resolving the filepath to the bundled flatbuffers. Will investigate further |
|
FWIW it might even be worthwhile to use Meson's wrap and subproject systems for flatbuffers instead of using a vendored copy. The limiting factor was that Arrow seems to statically assert the required major/minor version of flatbuffers, and the minor version requested does not exist in the wrapdb. If there is some flexibility on that version check we could go down that path |
|
We should add support for system Flatbuffers, right? (We can fallback to the vendored Flatbuffers and generated files when system Flatbuffers don't exist.) Could you open an issue for this? Let's discuss this in the new issue. |
|
@github-actions crossbow submit test-conda-cpp-meson |
|
Revision: c438216 Submitted crossbow builds: ursacomputing/crossbow @ actions-04885d5223
|
|
Looks like the current failure is due to a lack of boost in the crossbow environment. Boost doesn't exist in the wrapdb given its current size, but I might be able to create some custom wraps for it. Need to investigate further |
|
@github-actions crossbow submit test-conda-cpp-meson |
|
Revision: 3ea91f2699ec56e327d1398c1eb75133d196130d Submitted crossbow builds: ursacomputing/crossbow @ actions-c1928ec294
|
758a88b to
f000595
Compare
There was a problem hiding this comment.
This makes the initial setup pretty slow because it recurses a lot of unnecessary submodules in the boost repo. Didn't want to try and solve that now, but would be good to eventually fix
There was a problem hiding this comment.
Can we use boost-X.Y.Z-cmake.tar.xz instead?
For example, boost-1.87.0-cmake.tar.xz exists at https://github.com/boostorg/boost/releases/tag/boost-1.87.0 .
|
@github-actions crossbow submit test-conda-cpp-meson |
|
Revision: f0005959d735d8e4aeba3b478d8d5b6db45551e6 Submitted crossbow builds: ursacomputing/crossbow @ actions-0c64ef7f5a
|
There was a problem hiding this comment.
Do we need system too?
| modules: ['filesystem'], | |
| modules: ['filesystem', 'system'], |
There was a problem hiding this comment.
I don't believe we need that at the moment. If we do, I think we might need to also have filesystem_dep and system_dep be separate dependencies rather than included in one (unless we don't ever care to differentiate between them)
There was a problem hiding this comment.
Can we use boost-X.Y.Z-cmake.tar.xz instead?
For example, boost-1.87.0-cmake.tar.xz exists at https://github.com/boostorg/boost/releases/tag/boost-1.87.0 .
|
@github-actions crossbow submit test-conda-cpp-meson |
|
Revision: b4b615f Submitted crossbow builds: ursacomputing/crossbow @ actions-122520e76a
|
| source_filename = boost-1.87.0-cmake.tar.gz | ||
| source_hash = 78fbf579e3caf0f47517d3fb4d9301852c3154bfecdc5eeebd9b2b0292366f5b | ||
| directory = boost-1.87.0 | ||
| method=cmake |
There was a problem hiding this comment.
| method=cmake | |
| method = cmake |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b9d014d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Adding this singular test helps us make incremental progress on Meson as a build system generator
What changes are included in this PR?
A single array-test for libarrow is being added
Are these changes tested?
Yes - see CI
Are there any user-facing changes?
No - this is only for developers