You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++] Allow more Flatbuffers versions to compile Arrow #45636
Right now the project strictly requires the vendored version of flatbuffers, and places static assertions on main that the version of flatbuffers being used is 23.5.26
Instead of forcing the use of the vendored copy, we could open the project up to detecting a system dependency first, only falling back to the vendored copy when none is detected.
The origin of this conversation stems from the setup of the Meson build system in #45596 (comment)
So the more I've looked at this I've started to question if its worth the effort. From what I can read, it is a hard requirement for flatbuffers that the compiler and runtime versions match exactly. The odds of that are pretty low, so maybe not worth all of the extra CMake work here?
I think the easiest path to Meson support would be to upgrade the vendored flatbuffers that CMake uses to a version that also exists in Meson's WrapDB. I'll investigate that further
Closing as I don't think it is valuable to do this - flatbuffers requires the version used to create the proto files is exactly the same version used to compile them. It seems highly unlikely Arrow can find a system installed version that satisfies that requirement
Actually I think there is still value in this. If Arrow is used as a subproject of another project, then by nature of how it distributes flatbuffers-generated code today it requires that the host system use a specific version of flatbuffers even for the main project, which I think is rather limiting.
Instead of distributing the generated files as part of the source, we may want to look into generating the files during the build, so that we can open up flatbuffers to more than just a single version
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.
Activity
WillAyd commentedon Mar 5, 2025
So the more I've looked at this I've started to question if its worth the effort. From what I can read, it is a hard requirement for flatbuffers that the compiler and runtime versions match exactly. The odds of that are pretty low, so maybe not worth all of the extra CMake work here?
@kou
[-]Use System Provided Flatbuffers[/-][+][C++] Use System Provided Flatbuffers[/+]kou commentedon Mar 6, 2025
I thought this is one of blockers of Meson support. If so, I'll take a look at this.
WillAyd commentedon Mar 6, 2025
I think the easiest path to Meson support would be to upgrade the vendored flatbuffers that CMake uses to a version that also exists in Meson's WrapDB. I'll investigate that further
kou commentedon Mar 6, 2025
OK. Could you open a separated issue for upgrading the vendored Flatbuffers?
We may work on using system provided Flatbuffers later.
WillAyd commentedon Mar 7, 2025
Makes sense - see #45694
WillAyd commentedon Apr 22, 2025
Closing as I don't think it is valuable to do this - flatbuffers requires the version used to create the proto files is exactly the same version used to compile them. It seems highly unlikely Arrow can find a system installed version that satisfies that requirement
WillAyd commentedon May 8, 2025
Actually I think there is still value in this. If Arrow is used as a subproject of another project, then by nature of how it distributes flatbuffers-generated code today it requires that the host system use a specific version of flatbuffers even for the main project, which I think is rather limiting.
Instead of distributing the generated files as part of the source, we may want to look into generating the files during the build, so that we can open up flatbuffers to more than just a single version
WillAyd commentedon May 9, 2025
See also the conversation here mesonbuild/wrapdb#2099 (comment)
[-][C++] Use System Provided Flatbuffers[/-][+][C++] Allow more Flatbuffers versions to compile Arrow[/+]github-actions commentedon May 21, 2026
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.