Skip to content

GH-45433: [Python] Remove Cython workarounds - #45437

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh45433-cython-workarounds
Feb 6, 2025
Merged

pitrou merged 1 commit into
apache:mainfrom
pitrou:gh45433-cython-workarounds

Conversation

@pitrou

@pitrou pitrou commented Feb 5, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

We've accumulated multiple workarounds for various Cython issues over the years.

Now that we require at least Cython 3.0, we can remove some of those.

Are these changes tested?

Yes, by existing CI builds and tests.

Are there any user-facing changes?

No.

We've accumulated multiple workarounds for various Cython issues over the years.

Now that we require at least Cython 3.0, we can remove some of those.
@pitrou
pitrou requested a review from lidavidm as a code owner February 5, 2025 17:36
@pitrou

pitrou commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g python

@github-actions

github-actions Bot commented Feb 5, 2025

Copy link
Copy Markdown

Revision: c6fb259

Submitted crossbow builds: ursacomputing/crossbow @ actions-a84656ce93

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@pitrou

pitrou commented Feb 5, 2025

Copy link
Copy Markdown
Member Author

CI failures look unrelated.

@pitrou
pitrou merged commit e28fcd6 into apache:main Feb 6, 2025
@pitrou
pitrou deleted the gh45433-cython-workarounds branch February 6, 2025 07:20
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e28fcd6.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants