Skip to content

MINOR: [Python] Use libcpp.optional provided by Cython. - #45365

Closed
robertwb wants to merge 1 commit into
apache:mainfrom
robertwb:main
Closed

robertwb wants to merge 1 commit into
apache:mainfrom
robertwb:main

Conversation

@robertwb

Copy link
Copy Markdown

Rationale for this change

Now that arrow depends on Cython 3+, there's no need to include a custom definition of std::optional.

What changes are included in this PR?

Are these changes tested?

Should be covered by existing tests.

Are there any user-facing changes?

No.

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you create an issue for this change? Our definition of MINOR is only for minor documentation changes.

@pitrou

pitrou commented Feb 17, 2025

Copy link
Copy Markdown
Member

Hi @robertwb ! Thanks for the PR, unfortunately it looks like we both had the same idea and this was done as part of #45437 (which has a broader set of compatibility cleanups).

@pitrou pitrou closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants