Repository navigation
GH-44657: [CI][Dev] Add write permission to the crossbow comment bot - #44658
Conversation
…t bot It needs to write a comment to the target PR.
|
|
jonkeane
left a comment
There was a problem hiding this comment.
Oh, weird. That surprised me at first, but thinking about it again (+ realizing that permissions: pull-requests: write is about writing to the pull request on github itself, not the branch or anything which is what I had thought it was) of course it does.
Thanks and sorry for not catching that myself
|
No problem! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbda6b1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
It needs to write a comment to the target PR.
What changes are included in this PR?
Add write permission to only the crossbow comment bot.
Are these changes tested?
No.
Are there any user-facing changes?
No.
crossbow submitcan't write a comment to the target PR #44657