Skip to content

GH-44657: [CI][Dev] Add write permission to the crossbow comment bot - #44658

Merged
assignUser merged 1 commit into
apache:mainfrom
kou:ci-commit-comment-crossbow
Nov 6, 2024
Merged

assignUser merged 1 commit into
apache:mainfrom
kou:ci-commit-comment-crossbow

Conversation

@kou

@kou kou commented Nov 6, 2024 •

Copy link
Copy Markdown
Member

Rationale for this change

It needs to write a comment to the target PR.

What changes are included in this PR?

Add write permission to only the crossbow comment bot.

Are these changes tested?

No.

Are there any user-facing changes?

No.

…t bot

It needs to write a comment to the target PR.
@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #44657 has been automatically assigned in GitHub to PR creator.

@jonkeane jonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, weird. That surprised me at first, but thinking about it again (+ realizing that permissions: pull-requests: write is about writing to the pull request on github itself, not the branch or anything which is what I had thought it was) of course it does.

Thanks and sorry for not catching that myself

@kou

kou commented Nov 6, 2024

Copy link
Copy Markdown
Member Author

No problem!

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit bbda6b1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants