Skip to content

GH-44648: [CI] Remove autotune and rebase from commentbot - #44649

Merged
jonkeane merged 1 commit into
apache:mainfrom
jonkeane:no_more_autotune
Nov 5, 2024
Merged

jonkeane merged 1 commit into
apache:mainfrom
jonkeane:no_more_autotune

Conversation

@jonkeane

@jonkeane jonkeane commented Nov 5, 2024 •

Copy link
Copy Markdown
Member

Rationale for this change

Removing code that doesn't work

What changes are included in this PR?

Deleting from the workflow

Are these changes tested?

Changes are part of CI

Are there any user-facing changes?

No

@nealrichardson nealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish this worked but since it doesn't, 🚮


permissions:
contents: read
pull-requests: write

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, does the issue_assign job need this permission? I guess maybe not because it's modifying the issue and not the PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is also an empirical question (easiest to test on main, I'm happy to follow on if it stops working)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take is just fine: #44654 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is needed for @github-actions crossbow ...: #44658

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c6f076a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants