Skip to content

GH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Method - #42225

Merged
lidavidm merged 2 commits into
apache:mainfrom
llama90:ARROW-42224
Jun 21, 2024
Merged

GH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Method#42225
lidavidm merged 2 commits into
apache:mainfrom
llama90:ARROW-42224

Conversation

@llama90

@llama90 llama90 commented Jun 20, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Rationale for this change

Fixes a typo causing a NullPointerException in the test method

What changes are included in this PR?

  • Updating typo to fix Unit Test

Are these changes tested?

Yes

Are there any user-facing changes?

No.

@llama90
llama90 requested a review from lidavidm as a code owner June 20, 2024 16:47
@github-actions

github-actions Bot commented Jun 20, 2024

Copy link
Copy Markdown

⚠️ GitHub issue #42224 has been automatically assigned in GitHub to PR creator.

@llama90

llama90 commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

To verify this PR, I think we need to merge this PR.

@kou kou changed the title GH-42224: Fix Typo in TestAceroSubstraitConsumer Test Method GH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Method Jun 20, 2024
lidavidm
lidavidm approved these changes Jun 20, 2024
View reviewed changes

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase and then we can test

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 20, 2024
vibhatha
vibhatha reviewed Jun 21, 2024
View reviewed changes
Comment thread java/dataset/src/test/java/org/apache/arrow/dataset/substrait/TestAceroSubstraitConsumer.java Outdated

@vibhatha vibhatha Jun 21, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this diff?

@llama90 llama90 Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back this! It's typo.

@lidavidm

lidavidm commented Jun 21, 2024

Copy link
Copy Markdown
Member

@github-actions crossbow submit java-jars

@github-actions

github-actions Bot commented Jun 21, 2024

Copy link
Copy Markdown

Revision: b7bc29f

Submitted crossbow builds: ursacomputing/crossbow @ actions-add4e3a312

Task Status
java-jars GitHub Actions

@llama90

llama90 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

@lidavidm I've just finished rebasing! You are so fast!

@lidavidm

lidavidm commented Jun 21, 2024

Copy link
Copy Markdown
Member

Github notifies me on every push ^_^

@llama90 llama90 mentioned this pull request Jun 21, 2024
Merged
@lidavidm
lidavidm merged commit b71e71c into apache:main Jun 21, 2024
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Jun 21, 2024
@lidavidm lidavidm mentioned this pull request Jun 21, 2024
Closed
@conbench-apache-arrow

conbench-apache-arrow Bot commented Jun 21, 2024

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b71e71c.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@llama90 @kou
apacheGH-42224: [Java] Fix Typo in TestAceroSubstraitConsumer Test Me…
acedc7c 
…thod (apache#42225)

### Rationale for this change

Fixes a typo causing a `NullPointerException` in the test method

### What changes are included in this PR?

- Updating typo to fix Unit Test

### Are these changes tested?

Yes

### Are there any user-facing changes?

No.

* GitHub Issue: apache#42224

Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes
+1 more reviewer
@vibhatha vibhatha vibhatha left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llama90 @lidavidm @vibhatha