Repository navigation
GH-42208: [Java] Fix the Test in flight-sql-jdbc-driver Module - #42217
Conversation
|
|
|
@vibhatha Could you execute I found the reason, it was the wrong order of arguments in |
|
@github-actions crossbow submit java-jars |
| assertNotNull(driverClassURL, "Driver jar was not detected in the classpath"); | ||
| assertEquals( | ||
| "Driver jar was not detected in the classpath", "jar", driverClassURL.getProtocol()); | ||
| "jar", driverClassURL.getProtocol(), "Driver jar was not detected in the classpath"); |
There was a problem hiding this comment.
Both are strings, so the IDE won't complaint, but how did we miss this in the CIs in the first place?
There was a problem hiding this comment.
Also, I'm curious about that too.
Actually, I have executed multiple mvn clean install commands to verify the changes. I never saw that message before merging the PR (to deal with the Flight Module) into the main branch. 🥲
Perhaps, I suspect that this workflow might be cached, similar to how the JNI workflow failed.
There was a problem hiding this comment.
Probably... It is fine, let's move forward. Thanks for quickly working on this fix.
|
Revision: 065c92a Submitted crossbow builds: ursacomputing/crossbow @ actions-66f5fd63cd
|
github-actions
Bot
added
awaiting committer review
might be another thing to fix |
github-actions
Bot
added
awaiting merge
I checked the error, and it is caused by this PR. Can I open an issue and resolve it? |
kou
changed the title
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 27bbc3c. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#42217) ### Rationale for this change Adjust assertion message order for JUnit 5 compatibility. ### What changes are included in this PR? - Reordering the arguments of `assertEquals(expected, actual, message)` ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#42208 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
Adjust assertion message order for JUnit 5 compatibility.
What changes are included in this PR?
assertEquals(expected, actual, message)Are these changes tested?
Yes.
Are there any user-facing changes?
No.