Unable to build my project #8141

Activity

1. sboden commented on Oct 24, 2017

   

   sboden

   on Oct 24, 2017

   More actions

   You have a directory "C#Notes" ... remove the #.
2. filipesilva commented on Oct 25, 2017

   

   filipesilva

   on Oct 25, 2017

   Contributor

   More actions

   @sboden is right that this is caused by the # character, but we should fix this on our side as it is due to file resolving logic in Angular.
3. filipesilva

   self-assigned this

   on Oct 25, 2017
4. filipesilva

   added

   effort1: easy (hours)

   help wantedLabel noting an issue which the team is looking for contribution from the community to fixLabel noting an issue which the team is looking for contribution from the community to fix

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   type: bug/fix

   on Oct 25, 2017
5. sboden commented on Oct 25, 2017

   

   sboden

   on Oct 25, 2017

   More actions

   I agree the code should be fixed... short-term work around would be to remove # from the directory name.

   If this issue is fixed, issue #8118 will also be fixed I think.
6. sboden commented on Oct 25, 2017

   

   sboden

   on Oct 25, 2017

   More actions

   I debugged it, it ends up being in ngtools_impl.js which is in angular until v4.4.x and disappears in v5. So still have to check whether v5 is also affected.

   problem is following in Routedef:

   RouteDef.fromString = function (entry) {
       var split = entry.split('#');
       return new RouteDef(split[0], split[1] || null);
   };
   

   it gets passed e.g. "c:/projects/angular/c#notes/notes/src/app/app.module#AppModule", and the split() on # takes the wrong parts of the string.

   Following fixes it (it takes the part after the most right # and the whole part in front):

   RouteDef.fromString = function (entry) {
       var split = entry.split('#');
       return new RouteDef(split.slice(0, -1).join('#'), split.pop() || null);
   };
   
7. Brocco

   closed this as completedin #9236on Jan 18, 2018
8. angular-automatic-lock-bot commented on Sep 7, 2019

   

   angular-automatic-lock-botBot

   on Sep 7, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
9. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 7, 2019