If the path to the app contains "%20" the app doesn't work at all #8118

Activity

1. ludat

   changed the title [-]If the path to the app contains %20 the app doesn't work at all[/-] [+]If the path to the app contains "%20" the app doesn't work at all[/+] on Oct 22, 2017
2. filipesilva

   self-assigned this

   on Oct 25, 2017
3. filipesilva

   added

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   type: bug/fix

   on Oct 25, 2017
4. dinerotah commented on Jan 17, 2018

   

   dinerotah

   on Jan 17, 2018

   Contributor

   More actions

   this caused by webpack-dev-middleware module which consider the path as an encoded url so %20 is transformed to space.
   Here is where it happens:

   function getFilenameFromUrl(publicPath, outputPath, url) {
   var filename;

   // localPrefix is the folder our bundle should be in
   var localPrefix = urlParse(publicPath || "/", false, true);
   var urlObject = urlParse(url);

   // publicPath has the hostname that is not the same as request url's, should fail
   if(localPrefix.hostname !== null && urlObject.hostname !== null &&
   localPrefix.hostname !== urlObject.hostname) {
   return false;
   }

   // publicPath is not in url, so it should fail
   if(publicPath && localPrefix.hostname === urlObject.hostname && url.indexOf(publicPath) !== 0) {
   return false;
   }

   // strip localPrefix from the start of url
   if(urlObject.pathname.indexOf(localPrefix.pathname) === 0) {
   filename = urlObject.pathname.substr(localPrefix.pathname.length);
   }

   if(!urlObject.hostname && localPrefix.hostname &&
   url.indexOf(localPrefix.path) !== 0) {
   return false;
   }
   // and if not match, use outputPath as filename

   return querystring.unescape(filename ? pathJoin(outputPath, filename) : outputPath);
   }

   using lite-server and --watch fix the problem.
5. ludat commented on Jan 28, 2018

   

   ludat

   on Jan 28, 2018

   Author

   More actions

   I imagined something like that was the cause, this issue isn't really a blocker for me since it's easy to work around it, but until I figured it out I wasted a couple of days scratching my head.

   I just want to avoid future people from encountering this issue.
6. hansl

   unassigned

   filipesilva

   on Feb 6, 2018
7. filipesilva

   added

   comp: cli/serve

   and removed

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   type: bug/fix

   on Feb 14, 2018
8. filipesilva

   added

   area: @angular-devkit/build-angular

   and removed

   comp: cli/serve

   on Jun 8, 2018
9. ngbot

   added this to the needsTriage milestone on Jan 24, 2019
10. filipesilva

    added

    type: bug/fix

    freq1: lowOnly reported by a handful of users who observe it rarelyOnly reported by a handful of users who observe it rarely

    severity3: broken

    on Jan 28, 2019
11. ngbot

    modified the milestones: needsTriage, Backlog on Jan 28, 2019
12. mgechev commented on Aug 19, 2019

    

    mgechev

    on Aug 19, 2019

    Member

    More actions

    Looks like a problem with old version of the CLI. Let us close the issue for now. If it's still relevant, please open a new ticket with steps to reproduce and a minimal demo. Thanks!
13. mgechev

    closed this as completedon Aug 19, 2019
14. angular-automatic-lock-bot commented on Sep 19, 2019

    

    angular-automatic-lock-botBot

    on Sep 19, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
15. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 19, 2019