Repository navigation
Conversation
bvibber
added a commit
to bvibber/wasm2swf
that referenced
this pull request
Jan 1, 2020
Requires binaryen.js patch: WebAssembly/binaryen#2565
module.getNumFunctionTableSegments() gives the number of segments.
module.getFunctionTableSegmentInfoByIndex() yields:
```
{
offset,
functions: ["func1", "func2"]
}
```
Another piece for WebAssembly#2370
Contributor
|
Great stuff. |
Contributor
Author
|
Heh, didn't see yours... :) I like your version better, it has the import marker and can support non constant init I think? |
Contributor
|
Thanks, but you did well too. In my version, the offset is treated as a regular wasm expression. At some point, it could be relevant to use the same approach for |
Contributor
Author
|
Closing in favor of #2554 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module.getNumFunctionTableSegments() gives the number of segments.
module.getFunctionTableSegmentInfoByIndex() yields:
Another piece for #2370