Repository navigation
Add the GetFunctionTable JS API - #2554
Merged
Merged
Conversation
tlively
self-requested a review
January 2, 2020 20:55
tlively
reviewed
Jan 3, 2020
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
Nice work! I have a few comments around style and design consistency, but this looks good overall.
tlively
reviewed
Jan 16, 2020
tlively
approved these changes
Feb 19, 2020
| 'imported': Boolean(Module['_BinaryenIsFunctionTableImported'](module)), | ||
| 'segments': (function() { | ||
| var arr = []; | ||
| for (var i = 0, numSegments = Module['_BinaryenGetNumFunctionTableSegments'](module) ; i !== numSegments ; ++i) { |
Member
There was a problem hiding this comment.
Can you remove the spaces before the semicolons in this loop and the loops in the C and JS tests as well? Otherwise LGTM! Nice job 👍
Contributor
Author
There was a problem hiding this comment.
Done. Thanks a lot 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to the JS and C API for getting the ftable segments.