Repository navigation
[bugfix] audio: expose the selected voice to assistive technology - #258
Merged
FayeSpica merged 2 commits intoNov 10, 2026
Merged
Conversation
PCcoding666
requested review from
hsliuustc0106 and
princepride
as code owners
November 10, 2026 03:45
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
FayeSpica
approved these changes
Nov 10, 2026
FayeSpica
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! CI is green, and I verified the voice picker locally in Chromium in both English and Chinese. When switching voices, aria-pressed correctly moves to the newly selected voice.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose the current voice on its native selection button when the library reopens. The card highlight and the button’s
aria-pressedstate both compare the connection and voice ID. Voice selection and favoriting remain separately identifiable actions.Linked issue
Refs #205. Follows the selected-state accessibility feedback on #218.
Labels
type:bug,area:canvas,accessibility.Test plan
698 frontend tests passed. The TypeScript and Vite production build, bilingual messages, browser locale, browser manifest and diff checks passed.
The full voice-library workflow passed in isolated Chromium in en-US and zh-CN. It covers no initial selection, reopening with “Sample voice” selected, and switching to the uploaded narrator before reopening.
Against unmodified main, the browser found no pressed voice button after reopening with the saved “Sample voice”.
The full release matrix remains for CI. This checks the state exposed in Chromium. Spoken output with VoiceOver or NVDA was not separately tested.
Upstream Release checks reached the cold audio reload and hit the 15-second
waitForResponsetimeout at line 790. This is the unchanged wait at line 776 on the base branch, tracked in [fix] ci: Voice library Playwright TimeoutError flakes Release checks #250. It occurs after the selected-state assertions.I also tested this branch together with the proposed cold-reload fix ([test] ci: harden voice-library cold reopen waits #255,
acdfd3c3). Git merged the two branches cleanly. On macOS with Chromium 145 and Node 24.22.1, both English and Chinese workflows passed withVOICE_REOPEN_DELAY_MS=17000, including the selected-state checks, reopened media MIME and playback. This was a local integration run.Evidence that it works
Chromium’s Accessibility.getFullAXTree reported the following voice buttons in zh-CN. Every voice initially reported
pressed=false.Provider verification
Bilingual UI