Repository navigation
[test] ci: harden voice-library cold reopen waits - #255
Merged
Probiotics5333 merged 2 commits intoNov 10, 2026
Merged
Probiotics5333 merged 2 commits into
Probiotics5333 merged 2 commits into
Conversation
Use explicit 45-second cold-load and reopen waits while retaining the 15-second interaction timeout. Surface failed media HTTP responses directly and provide a deterministic slow-response probe. Refs ThinkFlowLab#250.
wangtiance
requested review from
hsliuustc0106 and
princepride
as code owners
November 10, 2026 02:55
2 of 3 tasks
…ce-library-waits # Conflicts: # tests/browser/voice_library.mjs
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Voice-library Release checks used the ordinary 15-second interaction budget for cold project recovery and reopened audio downloads. Give those waits explicit 45-second limits, navigate to DOMContentLoaded before checking application readiness, and report unsuccessful media GETs directly instead of hiding them behind a response timeout. Ordinary interactions retain their 15-second limit; existing persisted-job, adoption, asset identity, MIME and playback assertions remain.
Add an optional VOICE_REOPEN_DELAY_MS probe and bilingual instructions. No generation retry or product behavior changes.
Closes #250.
Validation
中文:冷启动和重开等待单独设为45秒,普通交互仍为15秒;错误媒体响应直接报告HTTP状态。最终双语17秒延迟回归通过,15秒旧预算负例按预期超时。未复现原始CI偶发失败,仍需GitHub CI验证。