Skip to content

Updating to allow to search over an element without a frameworkId - #450

Closed
omireault wants to merge 88 commits into
TestStack:masterfrom
omireault:master
Closed

omireault wants to merge 88 commits into
TestStack:masterfrom
omireault:master

Conversation

@omireault

Copy link
Copy Markdown

Feedback appreciated.

Jake Ginnivan and others added 30 commits August 4, 2013 12:59
… moved to the ValueProperty of the ValuePattern
…ave to pass a default through from the parent container (might affect other controls too)
Made ComboBox collapse itself after selection if item requested to select is already active and thus Select just returns.

Absence of this code leads to problems in case when client code tries to select already selected item. Then base.Select(itemText) or base.Select(index) do nothing and combo box stays open. Next user actions may not expect this which could lead to confusing results. For example, after selection in combo box client code wants to click on check box below - White emulates click on the place where check box is located, but combo box drop down is at the place, so some another item is selected. So, we have to close combo box regardless of the fact that selection did something.

For same reasons added ComboBox collapsing after getting SelectedItem and SelectedItemText.
…rn.Select() which throws InvalidOperationException for some reason.
If process exited already, then automationElement.Current.ProcessId throws COMException with E_FAIL. Hence, instead of getting processId every time, we'll take everything we need at ctor time and just use it afterwards.
…at IsSelected was false when checked, but already becomes true until control flow reaches pattern execution. Hence instead of falling back to patterns immediately, we'll wait a bit to give mouse click a chance to be handled.
For some reason, in UIA v3 ComboBox doesn't expose ExpandCollapsePattern. Instead it has button "Open" which can be clicked. This change abstracts required changes away.
Roemer and others added 14 commits January 13, 2016 10:09
…3 instead of TestStack.White to differenciate UIAComWrapper branch.
Made nupkg TestStack.White.Uia3 to differentiate UIAComWrapper packages
Fixed problem with combobox item selection
… to climb up the parent chain to find one. This avoids a Label element lookup returning multiple ControlType matches.
Must avoid accidental merge of last change in master into UIAComWrapper, hence this merge without the changes in question.
AsContainer functionality moved to internal to prevent problems in Get and Exist methods
@chrisf

chrisf commented Jul 11, 2016

Copy link
Copy Markdown

This helped fix my issue when trying to access the nodes on a tree view. Thanks!

It would be pretty hard to analyze changes since 0.13.0 release in full, so the hope is they would be updated since now more consistently.
@AustinMatherne

AustinMatherne commented Jul 25, 2016 •

Copy link
Copy Markdown
Contributor

This PR resolves #277.

Olivier Mireault added 4 commits September 13, 2016 09:07
This reverts commit 6c5d7ab, reversing
changes made to 8509dfa.
…rity in the use of the mouse. This solves a problem a drawing app could have where Drag and Drop isn't quite granular enough.
@omireault

Copy link
Copy Markdown
Author

@AustinMatherne Is there a status update for this? I am kinda new to the Git stuff, but I don't think this is been merged.

@AustinMatherne

Copy link
Copy Markdown
Contributor

It hasn't. The PR contains some stuff (mouse up down functions) outside the original scope which should be reverted before merging.

@omireault

Copy link
Copy Markdown
Author

Hmm, sorry, as I said, new to git. I thought the PR would only include the
commit I specified.

I will revert those changes and submit a new request for them.

On Tue, Sep 13, 2016, 5:41 PM Austin M. Matherne notifications@github.com
wrote:

It hasn't. The PR contains some stuff (mouse up down functions) outside
the original scope which should be reverted before merging.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#450 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD0EsfM0pqawhiMpmoROD6AznI3HYqDKks5qpzTAgaJpZM4JBogj
.

@omireault
omireault changed the base branch from master to configuration-cleanup September 28, 2016 20:30
@omireault
omireault changed the base branch from configuration-cleanup to master September 28, 2016 20:30
@omireault omireault closed this Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants