Repository navigation
AsContainer functionality moved to internal to prevent problems in Get and Exist methods - #452
Merged
Merged
Conversation
…s in Get and Exist methods
Contributor
|
Please, write a comment in code as well, not only in the commit comment, so that nobody would inadvertently break this again.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have public AsContainer fuction in UIItem and all calls of public funtions (exept properties) calls Interceptor, Focus for example. And we use AsContainer function in GetMultiple function so we have problem: when we seach for an item we interceptors because AsContainer is public. So I moved this function functionality in AsContainerInternal function, and use this function for internal contaner usage. You can still AsContainer public function if you want with interceptors.