You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: require Node ^20.19.0 || >=22.12.0 in engines - #8855
Narrows engines.node from >=20.19 to ^20.19.0 || >=22.12.0 in @tanstack/router-cli, @tanstack/router-generator, @tanstack/router-plugin and @tanstack/router-utils, the same four packages and the same range as #8817. This drops Node 21 and Node 22.0–22.11. Those versions don't enable require(esm) by default, and #8817's CommonJS builds use it to load the ESM-only Yuku parser. The maintainer chose to land the requirement before the code that needs it.
Only the engines fields change; the lockfile stays the same. A changeset (minor) is included, and it gives the reason.
The router CLI, generator, plugin, and utilities now require Node.js 20.19.x or Node.js 22.12 and later. Node.js 21 and Node.js 22.0–22.11 are no longer supported. Check that your Node.js version meets these requirements before upgrading to releases of these packages.
No actionable comments were generated in the recent review.
Walkthrough
Four TanStack Router packages now declare Node.js ^20.19.0 || >=22.12.0 as their supported engine range. A changeset records minor releases for these packages and states that Node.js 21 and Node.js 22.0–22.11 are no longer supported.
Changes: Node.js support
Layer / File(s)
Summary
Node engine support declarations packages/router-cli/package.json, packages/router-generator/package.json, packages/router-plugin/package.json, packages/router-utils/package.json, .changeset/node-engines-require-esm.md
The four package manifests specify Node.js `^20.19.0
No actionable merge-blocking issue is established by the supplied evidence. Normal checks should confirm the declared Node ranges before merging.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely states the main change: narrowing the supported Node.js engine range.
Description check
The description explains the engine changes, motivation, affected packages, unchanged lockfile, changeset, and AI authorship. It omits the template headings and explicit checklist confirmations, but t…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description explains the engine changes, motivation, affected packages, unchanged lockfile, changeset, and AI authorship. It omits the template headings and explicit checklist confirmations, but the core required information is present.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between bf3e6af and e32fb19.
Files selected for processing: 1
.changeset/node-engines-require-esm.md
Files skipped from review as they are similar to previous changes: 1
.changeset/node-engines-require-esm.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.
System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.
⚠️1 benchmark with a significant change ran on different hardware
Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.
Main landed parts of this PR separately against the old compiler
(#8851, #8852, #8853, #8855, #8856) and re-enabled the router-utils unit
tests (#8849): the PR already has each of them. The old-compiler files
main edited stay deleted; the entries keep the PR's implementation (same
esbuild error message). Main's changesets stay; the duplicated bullets
leave the PR's router-plugin, route generator and compiler core
changesets. The router plugin skill takes main's esbuild wording.
#8857 (route-group layouts typed with full path '/'): the PR's generator
already types them '/'. Main's test that a childless `_auth.tsx` next to
the index route conflicts is dropped: SPEC J1.15 makes that pair valid
here (route-paths.test.ts checks it through the router).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #8817 so the big PR can shrink.
Narrows
engines.nodefrom>=20.19to^20.19.0 || >=22.12.0in@tanstack/router-cli,@tanstack/router-generator,@tanstack/router-pluginand@tanstack/router-utils, the same four packages and the same range as #8817. This drops Node 21 and Node 22.0–22.11. Those versions don't enablerequire(esm)by default, and #8817's CommonJS builds use it to load the ESM-only Yuku parser. The maintainer chose to land the requirement before the code that needs it.Only the
enginesfields change; the lockfile stays the same. A changeset (minor) is included, and it gives the reason.🤖 Generated with Claude Code
Summary by CodeRabbit